Reorder search patterns for Pnpm component detection#1782
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Reorders pnpm detector search patterns so the current lockfile name (pnpm-lock.yaml) is prioritized over the legacy (shrinkwrap.yaml), aligning with the priority semantics introduced in #1770.
Changes:
- Reordered
SearchPatternsin the pnpm detector factory to preferpnpm-lock.yamlfirst.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.ComponentDetection.Detectors/pnpm/PnpmComponentDetectorFactory.cs | Updates pnpm lockfile search priority to prefer the modern filename. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1782 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
As a part of the change in #1770, I updated
SearchPatternsso that the earlier in the list, the higher the priority. Andshrinkwrap.yamlis the old name forpnpm-lock.yamlso it shouldn't be first in the order anymore: https://github.com/orgs/pnpm/discussions/8595#discussioncomment-10813709