Skip to content

Promote the DockerCompose, Dockerfile, and Helm detectors to default on.#1818

Open
jpinz wants to merge 1 commit into
mainfrom
jupinzer/promote_container_detectors_default
Open

Promote the DockerCompose, Dockerfile, and Helm detectors to default on.#1818
jpinz wants to merge 1 commit into
mainfrom
jupinzer/promote_container_detectors_default

Conversation

@jpinz
Copy link
Copy Markdown
Member

@jpinz jpinz commented Jun 4, 2026

This pull request removes the "experimental" status from three component detectors: Docker Compose, Dockerfile, and Helm. The detectors are now considered stable, and their outputs are included in scan results by default, without requiring special command-line arguments. Documentation has been updated to reflect this change, and the IExperimentalDetector interface has been removed from the relevant classes.

Detector status changes:

  • Removed the IExperimentalDetector interface from DockerComposeComponentDetector, DockerfileComponentDetector, and HelmComponentDetector, making them standard detectors. [1] [2] [3]

Documentation updates:

  • Updated docs/detectors/dockercompose.md to remove references to experimental status and the need for --DetectorArgs DockerCompose=Enable. [1] [2]
  • Updated docs/detectors/dockerfile.md to remove references to experimental status and the need for --DetectorArgs DockerReference=Enable. [1] [2]
  • Updated docs/detectors/helm.md to remove references to experimental status and the need for --DetectorArgs Helm=Enable. [1] [2]

These changes mean that users will now see Docker Compose, Dockerfile, and Helm detection results in their scans by default, improving usability and reducing configuration complexity.

@jpinz jpinz self-assigned this Jun 4, 2026
Copilot AI review requested due to automatic review settings June 4, 2026 16:47
@jpinz jpinz requested a review from a team as a code owner June 4, 2026 16:47
@jpinz jpinz requested a review from pauld-msft June 4, 2026 16:47
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request promotes the Docker Compose, Dockerfile, and Helm detectors from “experimental” to standard detectors so their detected components are included in scan results by default. This aligns with the orchestrator’s existing behavior where IExperimentalDetector implementations are excluded from results unless explicitly enabled.

Changes:

  • Removed IExperimentalDetector from DockerComposeComponentDetector, DockerfileComponentDetector, and HelmComponentDetector so their outputs are included in scan results by default.
  • Updated detector documentation pages to remove “experimental” messaging and opt-in --DetectorArgs ...=Enable instructions.
Show a summary per file
File Description
src/Microsoft.ComponentDetection.Detectors/dockercompose/DockerComposeComponentDetector.cs Stops treating Docker Compose detection as experimental by removing IExperimentalDetector.
src/Microsoft.ComponentDetection.Detectors/dockerfile/DockerfileComponentDetector.cs Stops treating Dockerfile image reference detection as experimental by removing IExperimentalDetector.
src/Microsoft.ComponentDetection.Detectors/helm/HelmComponentDetector.cs Stops treating Helm values image reference detection as experimental by removing IExperimentalDetector.
docs/detectors/dockercompose.md Removes experimental/opt-in wording now that results are included by default.
docs/detectors/dockerfile.md Removes experimental/opt-in wording now that results are included by default.
docs/detectors/helm.md Removes experimental/opt-in wording now that results are included by default.

Copilot's findings

  • Files reviewed: 6/6 changed files
  • Comments generated: 0

@jpinz
Copy link
Copy Markdown
Member Author

jpinz commented Jun 4, 2026

This PR is on hold until #1819 is merged and deployed. With validation that the timeouts for the helm detector has gone down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants