Skip to content

Target .NET Core 3.1 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2021
Merged

Target .NET Core 3.1 #19

merged 1 commit into from
Dec 9, 2021

Conversation

@JamieMagee
Copy link
Member

@JamieMagee JamieMagee commented Dec 9, 2021

Changes include:

  • Update global.json to require at least .NET Core 3.1.300 (this version specifically is required for centrally managing NuGet packages
  • Update GitHub Actions to install .NET Core 3.1
  • Update README.md to reflect the new requirements
  • Fully qualify a constructor in PodComponent
  • Add morelinq dependency to get DistinctBy

Closes #18

@JamieMagee
Target .NET Core 3.1
88384b7 
Changes include:

- Update `global.json` to require at least .NET Core 3.1.300 (this version specifically is required for centrally managing NuGet packages
- Update GitHub Actions to install .NET Core 3.1
- Update `README.md` to reflect the new requirements
- Fully qualify a constructor in `PodComponent`
- Add `morelinq` dependency to get `DistinctBy`

Closes #18
@JamieMagee JamieMagee requested a review from a team as a code owner December 9, 2021 23:27
@JamieMagee JamieMagee merged commit 69a379a into main Dec 9, 2021
@JamieMagee JamieMagee deleted the dotnet-core-3.1 branch December 9, 2021 23:43
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@JamieMagee JamieMagee added type:docs Documentation and removed documentation labels Dec 17, 2021
@JamieMagee JamieMagee added type:ci Build or repository configuration and removed repo-configuration type:docs Documentation labels Jan 3, 2022
@tofay tofay mentioned this pull request Jan 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcfiorenzano jcfiorenzano jcfiorenzano approved these changes

@FernandoRojo FernandoRojo Awaiting requested review from FernandoRojo FernandoRojo is a code owner automatically assigned from microsoft/ose-component-detection-maintainers

Assignees

No one assigned

Labels

type:ci Build or repository configuration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Target .NET Core 3.1

3 participants

@JamieMagee @jcfiorenzano