Skip to content

Make Vcpkg Experimental detector #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Make Vcpkg Experimental detector #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41f17ec
Make Vcpkg Experimental detector
grvillic Aug 23, 2022
aa85567
nit about experimental doc
grvillic Aug 23, 2022
ac72f26
Detector version bump for experimental changes
grvillic Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.ComponentDetection.Contracts/IComponentDetector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System.Collections.Generic;
using System.Collections.Generic;
using System.Threading.Tasks;
using Microsoft.ComponentDetection.Contracts.TypedComponent;

Expand Down Expand Up @@ -53,7 +53,7 @@ public interface IDefaultOffComponentDetector : IComponentDetector
/// <summary>
/// Component detectors implementing this interface are in an experimental state.
/// The detector processing service guarantees that:
/// They should NOT return their components as part of the scan result or be allowed to run too long (e.g. 2 min or less).
/// They should NOT return their components as part of the scan result or be allowed to run too long (e.g. 4 min or less).
/// They SHOULD submit telemetry about how they ran.
/// If opted in, they should behave like a normal detector.
/// </summary>
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.ComponentDetection.Detectors/vcpkg/VcpkgComponentDetector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using System.Composition;
using System.IO;
Expand All @@ -13,7 +13,7 @@
namespace Microsoft.ComponentDetection.Detectors.Vcpkg
{
[Export(typeof(IComponentDetector))]
public class VcpkgComponentDetector : FileComponentDetector, IDefaultOffComponentDetector
public class VcpkgComponentDetector : FileComponentDetector, IExperimentalDetector
{
[Import]
public ICommandLineInvocationService CommandLineInvocationService { get; set; }
Expand All @@ -29,7 +29,7 @@ public class VcpkgComponentDetector : FileComponentDetector, IDefaultOffComponen

public override IEnumerable<ComponentType> SupportedComponentTypes { get; } = new[] { ComponentType.Vcpkg };

public override int Version => 1;
public override int Version => 2;

private HashSet<string> projectRoots = new HashSet<string>();

Expand Down