Skip to content

Conversation

@tofay
Copy link
Contributor

@tofay tofay commented Dec 14, 2021

This detects python dependencies from poetry lockfiles.

New Detector Checklist

  • I have gone through the docs for creating a new detector here
  • My new detector implements IDefaultOffComponentDetector
  • I have created a PR to the verification repo with components that my new detector can find. That's here
  • (If necessary) I have updated the Feature Overview table in the README

@tofay tofay requested a review from a team as a code owner December 14, 2021 15:24
@tofay tofay requested a review from jcfiorenzano December 14, 2021 15:24
@github-actions
Copy link

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Copy link
Member

@tevoinea tevoinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!

@tevoinea tevoinea enabled auto-merge (squash) December 15, 2021 14:43
@tevoinea tevoinea merged commit 11935c1 into main Dec 15, 2021
@tevoinea tevoinea deleted the tofay/poetry branch December 15, 2021 14:46
@JamieMagee JamieMagee added enhancement type:feature Feature (new functionality) and removed documentation labels Dec 17, 2021
@JamieMagee JamieMagee added detector:poetry The poetry detector and removed component-detection labels Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

detector:poetry The poetry detector type:feature Feature (new functionality)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants