Skip to content

Make vcpkg logging non-warning #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Make vcpkg logging non-warning #299

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e8e131
Make vcpkg logging non-warning
cobya Oct 13, 2022
840a13c
Update VcpkgComponentDetector.cs
cobya Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.ComponentDetection.Detectors/vcpkg/VcpkgComponentDetector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ protected override async Task OnFileFound(ProcessRequest processRequest, IDictio
var singleFileComponentRecorder = processRequest.SingleFileComponentRecorder;
var file = processRequest.ComponentStream;

this.Logger.LogWarning($"vcpkg detector found {file}");
this.Logger.LogInfo($"vcpkg detector found {file}");

var projectRootDirectory = Directory.GetParent(file.Location);
if (this.projectRoots.Any(path => projectRootDirectory.FullName.StartsWith(path)))
Expand Down Expand Up @@ -78,7 +78,7 @@ private async Task ParseSpdxFile(
continue;
}

this.Logger.LogWarning($"parsed package {item.Name}");
this.Logger.LogVerbose($"vcpkg parsed package {item.Name}");
if (item.SPDXID == "SPDXRef-port")
{
var split = item.VersionInfo.Split('#');
Expand Down