Skip to content

Add linux detection to Verification test#312

Merged
RushabhBhansali merged 12 commits into
mainfrom
users/rbhansali/add-linux-detection-verification-test
Oct 20, 2022
Merged

Add linux detection to Verification test#312
RushabhBhansali merged 12 commits into
mainfrom
users/rbhansali/add-linux-detection-verification-test

Conversation

@RushabhBhansali
Copy link
Copy Markdown
Contributor

@RushabhBhansali RushabhBhansali commented Oct 19, 2022

Summary:

Add linux detection to verification tests.

closed #307

Details:

Adding linux component detection for following 3 images in verification tests.

  • docker.io/library/debian@sha256:9b0e3056b8cd8630271825665a0613cc27829d6a24906dc0122b3b4834312f7d
  • mcr.microsoft.com/cbl-mariner/base/core@sha256:c1bc83a3d385eccbb2f7f7da43a726c697e22a996f693a407c35ac7b4387cd59
  • docker.io/library/alpine@sha256:1304f174557314a7ed9eddb4eab12fed12cb0cd9809e4c28f29af86979a3c870

verification test failure:

since this PR adds linux detection in verification test, the previous snapshot release does not contain linux detection. Hence, comparison is failing for linux detection.

@github-actions
Copy link
Copy Markdown

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@RushabhBhansali RushabhBhansali marked this pull request as ready for review October 19, 2022 18:47
@RushabhBhansali RushabhBhansali requested a review from a team as a code owner October 19, 2022 18:47
Comment thread .github/workflows/snapshot-verify.yml Outdated
Comment thread .github/workflows/snapshot-publish.yml Outdated
Copy link
Copy Markdown
Member

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments inline

@RushabhBhansali RushabhBhansali enabled auto-merge (squash) October 19, 2022 23:34
@RushabhBhansali RushabhBhansali merged commit f040ee5 into main Oct 20, 2022
@RushabhBhansali RushabhBhansali deleted the users/rbhansali/add-linux-detection-verification-test branch October 20, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add linux detection to verification tests

2 participants