-
Notifications
You must be signed in to change notification settings - Fork 114
Add output log of skipped / failed components #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… into users/coallred/SkipLog
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
src/Microsoft.ComponentDetection.Common/DependencyGraph/ComponentRecorder.cs
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Common/DependencyGraph/ComponentRecorder.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Common/DependencyGraph/ComponentRecorder.cs
Outdated
Show resolved
Hide resolved
|
There are now some places where we log in the detector that we're not able to parse a package, and some places where we don't. We not also provide a summary of skipped or unparseable packages at the end of the run. Is it necessary to log directly in the detector if we're providing a summary at the end? |
The purpose of having the summary at the end is not to provide detailed exception messages of why it has been skipped - that should be done in the detector. The summary is to quickly show users how many components were skipped so they can investigate further. |
… into users/coallred/SkipLog
Add output log of skipped or failed components to the end of the build post detector summary. A log group will be created for each detector which has failed components.