Skip to content

Conversation

@cobya
Copy link
Contributor

@cobya cobya commented Feb 14, 2023

Add output log of skipped or failed components to the end of the build post detector summary. A log group will be created for each detector which has failed components.

image

@cobya cobya requested a review from a team as a code owner February 14, 2023 21:45
@cobya cobya requested a review from jcfiorenzano February 14, 2023 21:45
@github-actions
Copy link

github-actions bot commented Feb 14, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@JamieMagee
Copy link
Member

There are now some places where we log in the detector that we're not able to parse a package, and some places where we don't. We not also provide a summary of skipped or unparseable packages at the end of the run.

Is it necessary to log directly in the detector if we're providing a summary at the end?

@cobya
Copy link
Contributor Author

cobya commented Feb 17, 2023

There are now some places where we log in the detector that we're not able to parse a package, and some places where we don't. We not also provide a summary of skipped or unparseable packages at the end of the run.

Is it necessary to log directly in the detector if we're providing a summary at the end?

The purpose of having the summary at the end is not to provide detailed exception messages of why it has been skipped - that should be done in the detector. The summary is to quickly show users how many components were skipped so they can investigate further.

@cobya cobya merged commit f3175cc into main Feb 17, 2023
@cobya cobya deleted the users/coallred/SkipLog branch February 17, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants