Skip to content

Don't allow re-init of Logger class #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Don't allow re-init of Logger class #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/Microsoft.ComponentDetection.Common/Logger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ public Logger(IConsoleWritingService consoleWriter, IFileWritingService fileWrit

private VerbosityMode Verbosity { get; set; }

private bool Initialized { get; set; }

private bool WriteToFile { get; set; }

private bool WriteLinePrefix { get; set; }
Expand All @@ -30,10 +32,19 @@ public void Init(VerbosityMode verbosity, bool writeLinePrefix = true)
this.WriteToFile = true;
this.Verbosity = verbosity;
this.WriteLinePrefix = writeLinePrefix;

// If initialization has already completed, don't attempt to create
// the log file again as this throws an exception
if (this.Initialized)
{
return;
}

try
{
this.fileWritingService.WriteFile(LogRelativePath, string.Empty);
this.LogInfo($"Log file: {this.fileWritingService.ResolveFilePath(LogRelativePath)}");
this.Initialized = true;
}
catch (Exception)
{
Expand Down