-
Notifications
You must be signed in to change notification settings - Fork 113
ci: replace verification repository #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c6ce3c4 to
2140cb4
Compare
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The verification repo for pip has to have the dependencies frozen:
These are the steps that need to be followed for pip
Instead you want to:
Create a new virtual env (see [here](https://packaging.python.org/guides/installing-using-pip-and-virtual-environments/))
Activate the virtual env
pip install -r requirements.txt
pip freeze
Pip freeze will write out to a console, so you can either pipe to a requirements.txt.
|
I would also add the steps to the Contribution (or README) about how to add a new verification repo |
2140cb4 to
a66fc88
Compare
b9f508e to
de46c22
Compare
|
After discussing with @jcfiorenzano, I've decided to create some synthetic verification/integration/e2e tests instead. Checking out other repositories is flaky, and overall not a reliable method for this style of test. |
|
There is a file |
|
I would add a note in this document https://github.com/microsoft/component-detection/blob/main/docs/creating-a-new-detector.md. Explaining how and where to add a new verification repo. |
Good catch. It's left over from testing locally
Will do! |
This PR migrates from using a private repository, componendetection-verification, and moves verification tests into this repo. The verification tests have been rewritten to be minimal projects that exercise all functionality of a detector.
The current verification tests are expected to fail in this PR as the most recent snapshots are for the old verification projects.
Closes #44