Skip to content

Conversation

@JamieMagee
Copy link
Member

@JamieMagee JamieMagee commented Jan 19, 2022

This PR migrates from using a private repository, componendetection-verification, and moves verification tests into this repo. The verification tests have been rewritten to be minimal projects that exercise all functionality of a detector.

The current verification tests are expected to fail in this PR as the most recent snapshots are for the old verification projects.

Closes #44

@JamieMagee JamieMagee requested a review from a team as a code owner January 19, 2022 22:03
@JamieMagee JamieMagee requested a review from chsalgado January 19, 2022 22:03
@github-actions
Copy link

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@JamieMagee JamieMagee requested a review from cobya January 19, 2022 22:05
@JamieMagee JamieMagee added the type:ci Build or repository configuration label Jan 26, 2022
Copy link
Contributor

@jcfiorenzano jcfiorenzano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The verification repo for pip has to have the dependencies frozen:
These are the steps that need to be followed for pip

Instead you want to:

Create a new virtual env (see [here](https://packaging.python.org/guides/installing-using-pip-and-virtual-environments/))
Activate the virtual env
pip install -r requirements.txt
pip freeze
Pip freeze will write out to a console, so you can either pipe to a requirements.txt.

@jcfiorenzano
Copy link
Contributor

I would also add the steps to the Contribution (or README) about how to add a new verification repo

@JamieMagee
Copy link
Member Author

After discussing with @jcfiorenzano, I've decided to create some synthetic verification/integration/e2e tests instead. Checking out other repositories is flaky, and overall not a reliable method for this style of test.

@jcfiorenzano
Copy link
Contributor

There is a file ivi.jar at the repo root. Is that intendend?

@jcfiorenzano
Copy link
Contributor

I would add a note in this document https://github.com/microsoft/component-detection/blob/main/docs/creating-a-new-detector.md. Explaining how and where to add a new verification repo.

@JamieMagee
Copy link
Member Author

There is a file ivi.jar at the repo root. Is that intendend?

Good catch. It's left over from testing locally

I would add a note in this document main/docs/creating-a-new-detector.md. Explaining how and where to add a new verification repo.

Will do!

@JamieMagee JamieMagee merged commit 5393736 into main Feb 1, 2022
@JamieMagee JamieMagee deleted the ci/verification branch February 1, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:ci Build or repository configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace verification repository

3 participants