Skip to content

Conversation

@melotic
Copy link
Member

@melotic melotic commented Mar 10, 2023

Properly handles Rquires-Dist like so:

Requires-Dist: numpy<1.27.0,>=1.19.5

Also, properly handles dependencies with optional dependencies in pip METADATA or in requirements.txt. We ignore them for now.

Requires-Dist: PyJWT[crypto] (<3,>=1.0.0)

@melotic melotic added version:minor type:bug Bug fix of existing functionality detector:pip The pip detector labels Mar 10, 2023
@melotic melotic requested a review from a team as a code owner March 10, 2023 21:01
@melotic melotic requested a review from cobya March 10, 2023 21:01
@melotic
Copy link
Member Author

melotic commented Mar 10, 2023

I've tested this on a customer's repo who was reporting failures like https://pypi.org/pypi/PyJWT[crypto]/json and https://pypi.org/pypi/numpy<1.27.0,>=1.19.5/json.

This does not fix incorrectly resolving cv2, however.

@JamieMagee
Copy link
Member

This does not fix incorrectly resolving cv2, however.

Can you remove the Fixes #241 so the issue stays open?

@melotic melotic merged commit 8648074 into main Mar 13, 2023
@melotic melotic deleted the justinperez/fix-pip-invalid-packages branch March 13, 2023 18:42
@github-actions
Copy link

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

detector:pip The pip detector type:bug Bug fix of existing functionality version:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants