Skip to content

Conversation

@grvillic
Copy link
Collaborator

Context

Individual custom component file locations can't be added due to removal in DefaultGraphTranslationService. The service should verify they are under root and they are relative.#476

Solution

The DefaultGraphTranslationService already adds the file location where the detector was executed to the components, allow other custom locations to be added under same root (making them relative beforehand)

@grvillic grvillic requested a review from a team as a code owner April 10, 2023 16:41
@grvillic grvillic requested a review from chsalgado April 10, 2023 16:41
@melotic melotic added the type:bug Bug fix of existing functionality label Apr 10, 2023
@grvillic grvillic enabled auto-merge (squash) April 10, 2023 16:50
@grvillic grvillic merged commit 9a5fff2 into main Apr 10, 2023
@grvillic grvillic deleted the users/grvillic/RemoveCustomFilePaths branch April 10, 2023 16:58
@github-actions
Copy link

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Bug fix of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants