Skip to content

Conversation

@melotic
Copy link
Member

@melotic melotic commented Apr 11, 2023

Separates the lock file 3 specific code into a new detector.

@melotic melotic requested a review from a team as a code owner April 11, 2023 20:17
@melotic melotic requested a review from FernandoRojo April 11, 2023 20:17
@melotic melotic changed the title Justinperez/npm lockfile3 detector refactor(npm): separate lockfile 3 detector Apr 11, 2023
@github-actions
Copy link

github-actions bot commented Apr 11, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Copy link
Member

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diffs make this hard to review, but I think this is mostly just a copy-paste of existing code.

@melotic
Copy link
Member Author

melotic commented Apr 12, 2023

The CI run gives me confidence this is okay:

[19:07:54 INF] |______________________________|______________________________|______________________________|________________________________________|
[19:07:54 INF] |NpmLockfile3 (Beta)           |3.3 seconds                   |0                             |0                                       |
[19:07:54 INF] |______________________________|______________________________|______________________________|________________________________________|
[19:07:54 INF] |NpmWithRoots                  |3.3 seconds                   |59                            |4                                       |
[19:07:54 INF] |______________________________|______________________________|______________________________|________________________________________|

The (Beta) also indicates this is properly being run as an experimental detector:

providerElapsedTime.TryAdd(detector.Id + (isExperimentalDetector ? " (Beta)" : string.Empty), new DetectorRunResult

We would have also failed CI if we detected less components in the original NpmWithRoots detector.

@melotic melotic merged commit f4ea6f9 into main Apr 12, 2023
@melotic melotic deleted the justinperez/npm-lockfile3-detector branch April 12, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants