-
Notifications
You must be signed in to change notification settings - Fork 114
feat: add detector experiments #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
src/Microsoft.ComponentDetection.Orchestrator/Experiments/Models/Experiment.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Orchestrator/Experiments/Models/ExperimentDiff.cs
Outdated
Show resolved
Hide resolved
JamieMagee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only tiny comments on naming. Otherwise, looks good. Approving so as not to block.
This adds the ability to conduct experiments on a set of detectors, allowing us to compare the detected components of detectors.
We take diffs of the components with respect to:
The output diff is serialized to a JSON model and written to disk. A future PR will send this data as telemetry.
Current Experiments
Nuget Detector
Control Group:
NuGetComponentDetectorandNuGetProjectModelProjectCentricComponentDetectorExperimental Group:
NuGetPackagesConfigDetectorandNuGetProjectModelProjectCentricComponentDetectorNPM With Roots Detector
Control Group:
NpmComponentDetectorExperimental Group:
NpmLockfile3detector.