Skip to content

Conversation

@melotic
Copy link
Member

@melotic melotic commented Apr 13, 2023

This adds the ability to conduct experiments on a set of detectors, allowing us to compare the detected components of detectors.

We take diffs of the components with respect to:

  • Component IDs
  • Root components
  • Is a development dependency

The output diff is serialized to a JSON model and written to disk. A future PR will send this data as telemetry.

Current Experiments

Nuget Detector

Control Group: NuGetComponentDetector and NuGetProjectModelProjectCentricComponentDetector
Experimental Group: NuGetPackagesConfigDetector and NuGetProjectModelProjectCentricComponentDetector

NPM With Roots Detector

Control Group: NpmComponentDetector
Experimental Group: NpmLockfile3 detector.

@melotic melotic added version:minor type:feature Feature (new functionality) labels Apr 13, 2023
@melotic melotic requested a review from a team as a code owner April 13, 2023 17:32
@melotic melotic requested a review from cobya April 13, 2023 17:32
@github-actions
Copy link

github-actions bot commented Apr 13, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Copy link
Member

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only tiny comments on naming. Otherwise, looks good. Approving so as not to block.

@melotic melotic merged commit e290c73 into main Apr 13, 2023
@melotic melotic deleted the justinperez/detector-experiments branch April 13, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature Feature (new functionality) version:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants