fix(experiment): don't process if empty or tainted #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts' into justinperez/skip-empty-experiments
melotic
changed the title
JamieMagee
reviewed
Apr 24, 2023
src/Microsoft.ComponentDetection.Orchestrator/Experiments/Configs/NewNugetExperiment.cs
Show resolved
Hide resolved
JamieMagee
reviewed
Apr 24, 2023
src/Microsoft.ComponentDetection.Orchestrator/Experiments/ExperimentService.cs
Outdated
Show resolved
Hide resolved
JamieMagee
approved these changes
Apr 24, 2023
amitla1
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging in
ExperimentServicewas broken as it contained two identical{Count}parameters.In addition, if the results of an experiment are completely empty (i.e. no components detected in the control group and experiment group), we should skip processing as an empty diff is indicative of a perfect detector.
Lastly, certain detectors running invalidates the experiment results. For instance, in the NPM Lockfile v3 experiment, if the lockfile v2 detector runs, we would be comparing the
NpmComponentDetector(which would detect N components), to theNpmLockfile3Detector(which would detect 0 components). So, the experiment is tainted and we should not process it.