Initial implementation of VcpkgDetector and VcpkgComponent#52
Conversation
|
+@grvillic for review |
…component-detection into dev/roschuma/vcpkg
|
Moving this to draft for now. There's still an open question about a generic SPDX detector. |
7900522 to
b770382
Compare
…tDetector.cs Co-authored-by: Greg Villicana <58237075+grvillic@users.noreply.github.com>
grvillic
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
|
|
||
| namespace Microsoft.ComponentDetection.Contracts.TypedComponent | ||
| { | ||
| public class VcpkgComponent : TypedComponent |
There was a problem hiding this comment.
Can we add tests for this new detector? See other detector test samples in Microsoft.ComponentDetection.Detectors.Tests.
grvillic
left a comment
There was a problem hiding this comment.
We need to add tests validating the new detector.
…tDetector.cs Co-authored-by: Greg Villicana <58237075+grvillic@users.noreply.github.com>
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
| var components = detectedComponents.ToList(); | ||
|
|
||
| Assert.AreEqual(2, components.Count()); | ||
| { |
There was a problem hiding this comment.
We don't need these curly brackets here. you will can just set the variable below without initializing it (without var)
This PR contains an initial implementation of detecting SPDX files produced by vcpkg. This depends upon experimental features that are not yet released in the vcpkg tool. (microsoft/vcpkg-tool#296)
New Detector Checklist
IDefaultOffComponentDetector