Add Pypi Dev parsing test #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grvillic
commented
Jan 31, 2022
| Assert.AreEqual(pythonVersion.PreReleaseLabel, "rc"); | ||
| Assert.AreEqual(pythonVersion.PostNumber, 99); | ||
| Assert.AreEqual(pythonVersion.DevNumber, 2); | ||
| Assert.AreEqual(4, pythonVersion.Epoch); |
Collaborator
Author
There was a problem hiding this comment.
nit: Argument sorting here. "expected value", "actual value"
jcfiorenzano
approved these changes
Jan 31, 2022
JamieMagee
approved these changes
Jan 31, 2022
Member
|
Verification test failure. Re-running. Bug is already logged here #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add a missing Pip test to our suite that verifies the correct handling of a "dev" version.