Skip to content

Conversation

@melotic
Copy link
Member

@melotic melotic commented Jul 5, 2023

Every PR runs two copies of the smoke test, one because a user pushed to their local branch, and another from the pull request trigger.

I think it's best to leave push and pull_request triggers, as I'm not sure if push will trigger on a PR from a fork.

Every PR runs two copies of the smoke test, one because a user pushed to their local branch, and another from the pull request trigger.

I think it's best to leave `push` and `pull_request` triggers, as I'm not sure if `push` will trigger on a PR from a fork.
@melotic melotic requested a review from a team as a code owner July 5, 2023 18:20
@melotic melotic requested a review from amitla1 July 5, 2023 18:20
@melotic melotic added the type:ci Build or repository configuration label Jul 5, 2023
@JamieMagee JamieMagee merged commit bd522a4 into main Jul 7, 2023
@JamieMagee JamieMagee deleted the justinperez/smoke-test-limit branch July 7, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:ci Build or repository configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants