fix: gate dashboard URL prints behind is_verbose() for --silent compliance#210
Closed
wjgong001 wants to merge 1 commit into
Closed
fix: gate dashboard URL prints behind is_verbose() for --silent compliance#210wjgong001 wants to merge 1 commit into
wjgong001 wants to merge 1 commit into
Conversation
…iance Fixes microsoft#209. Three locations still printed the dashboard URL to stderr even when --silent was set, breaking the 'No progress output' contract: 1. src/conductor/cli/app.py:990-991 — replay command dashboard URL 2. src/conductor/cli/run.py:1173 — foreground dashboard URL 3. src/conductor/cli/run.py:1685 — foreground dashboard URL Each is now gated by , matching the pattern already established in verbose_log() and the microsoft#201/microsoft#203 fix for --web-bg mode. Dashboard failure warnings (Exception handler) are left ungated since they communicate actual errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #209. Three locations still printed the dashboard URL to stderr even when --silent was set, violating the "No progress output. Only JSON result on stdout." contract.
Changes
# Print URL to stderr regardless of --silent/--quietcomment since that behavior was the bug.All three match the pattern established in the existing verbose_log() helper and the #201/#203 fix for --web-bg mode.
Verification
Before this fix:
After this fix:
Dashboard failure warnings (Exception handler in run.py) are left ungated since they communicate actual errors that users should see regardless of verbosity mode.