Skip to content

fix(cli): gate remaining dashboard URL prints behind is_verbose() for --silent compliance #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wjgong001 wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −14
Open

fix(cli): gate remaining dashboard URL prints behind is_verbose() for --silent compliance #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/conductor/cli/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,7 +991,8 @@ async def _run_replay() -> None:
raise typer.Exit(1) from exc

await dashboard.start()
console.print(f"\n[bold green]▶ Replay dashboard:[/] {dashboard.url}\n")
if is_verbose():
console.print(f"\n[bold green]▶ Replay dashboard:[/] {dashboard.url}\n")
console.print("[dim]Press Ctrl+C to exit[/dim]\n")

try:
Expand Down
33 changes: 20 additions & 13 deletions src/conductor/cli/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,8 +1170,9 @@ async def run_workflow_async(

try:
await dashboard.start()
# Print URL to stderr regardless of --silent/--quiet
_verbose_console.print(f"[bold cyan]Dashboard:[/bold cyan] {dashboard.url}")
from conductor.cli.app import is_verbose
if is_verbose():
_verbose_console.print(f"[bold cyan]Dashboard:[/bold cyan] {dashboard.url}")
except Exception as e:
_verbose_console.print(
f"[bold yellow]Warning:[/bold yellow] "
Expand Down Expand Up @@ -1316,11 +1317,13 @@ async def run_workflow_async(
if is_bg:
await dashboard.wait_for_clients_disconnect()
else:
_verbose_console.print(
f"\n[bold green]Workflow complete.[/bold green] "
f"Dashboard still running at {dashboard.url} — "
f"press [bold]Ctrl+C[/bold] to exit."
)
from conductor.cli.app import is_verbose
if is_verbose():
_verbose_console.print(
f"\n[bold green]Workflow complete.[/bold green] "
f"Dashboard still running at {dashboard.url} — "
f"press [bold]Ctrl+C[/bold] to exit."
)
with contextlib.suppress(asyncio.CancelledError):
await asyncio.Event().wait()

Expand Down Expand Up @@ -1829,7 +1832,9 @@ async def resume_workflow_async(

try:
await dashboard.start()
_verbose_console.print(f"[bold cyan]Dashboard:[/bold cyan] {dashboard.url}")
from conductor.cli.app import is_verbose
if is_verbose():
_verbose_console.print(f"[bold cyan]Dashboard:[/bold cyan] {dashboard.url}")
except Exception as e:
_verbose_console.print(
f"[bold yellow]Warning:[/bold yellow] "
Expand Down Expand Up @@ -1879,11 +1884,13 @@ async def resume_workflow_async(
if is_bg:
await dashboard.wait_for_clients_disconnect()
else:
_verbose_console.print(
f"\n[bold green]Workflow complete.[/bold green] "
f"Dashboard still running at {dashboard.url} — "
f"press [bold]Ctrl+C[/bold] to exit."
)
from conductor.cli.app import is_verbose
if is_verbose():
_verbose_console.print(
f"\n[bold green]Workflow complete.[/bold green] "
f"Dashboard still running at {dashboard.url} — "
f"press [bold]Ctrl+C[/bold] to exit."
)
with contextlib.suppress(asyncio.CancelledError):
await asyncio.Event().wait()

Expand Down