-
Notifications
You must be signed in to change notification settings - Fork 28
Custom xml #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom xml #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for custom XML parts to Excel workbooks, specifically for registering Connected Workbooks metadata. The implementation includes utility functions for managing custom XML items, updating content types and relationships, and integrating custom XML generation into the workbook creation pipeline.
- Introduces comprehensive custom XML support with proper workbook registration
- Adds utility functions for determining item numbers, checking existence, and managing relationships
- Integrates custom XML addition into the main workbook generation workflow
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/xmlInnerPartsUtils.test.ts | Adds test cases for custom XML addition functionality |
| src/workbookManager.ts | Minor type casting improvements for template file handling |
| src/utils/xmlPartsUtils.ts | Adds main orchestration function for custom XML workbook integration |
| src/utils/xmlInnerPartsUtils.ts | Implements core utility functions for custom XML management |
| src/utils/constants.ts | Defines constants, templates, and configuration for custom XML support |
| package.json | Updates version to 3.3.3-beta |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
refactor Error messages
This pull request introduces support for adding custom XML parts to generated Excel workbooks, specifically for registering Connected Workbooks metadata. The changes include new utilities for managing custom XML items, updating content types and relationships, and integrating these steps into the workbook generation process. Additionally, several constants and error messages were added to support these features.
Custom XML support for Connected Workbooks:
Added new utility functions in
xmlInnerPartsUtils.tsto:Introduced a new function
addCustomXMLToWorkbookinxmlPartsUtils.tsthat orchestrates the creation and registration of custom XML items when generating a workbook.Integrated the custom XML addition step into the main workbook generation pipeline in
workbookManager.ts.Constants and error handling enhancements:
constants.tsfor custom XML paths, folder names, XML element/attribute names, error messages, and custom XML content templates.Other minor improvements:
package.jsonto3.4.0-beta.These changes ensure that every generated workbook includes the necessary custom XML data and registrations for Connected Workbooks, improving interoperability and metadata support.