Skip to content

fix: update deployment#281

Merged
Roopan-Microsoft merged 2 commits intodevfrom
dgtemplate
Mar 18, 2025
Merged

fix: update deployment#281
Roopan-Microsoft merged 2 commits intodevfrom
dgtemplate

Conversation

@malrose07
Copy link
Copy Markdown
Contributor

@malrose07 malrose07 commented Mar 18, 2025

Purpose

  • This pull request includes significant updates to the infrastructure deployment scripts to improve resource management and deployment processes. The changes introduce new parameters, resources, and deployment scripts, along with modifications to existing resources and outputs.

Key Changes:

Resource Management Enhancements:

  • Added a new logAnalytics resource to the infra/deploy_ai_foundry.bicep file for better logging and monitoring.
  • Introduced new parameters for solutionLocation, baseUrl, keyVaultName, and identity in infra/deploy_index_scripts.bicep to specify resource locations and identities.
  • Updated the infra/deploy_post_deployment_scripts.bicep with new parameters and resources for container app deployment and log analytics configuration.
  • Added a new deployment script for copying demo data in infra/deploy_upload_files_script.bicep to streamline data setup.

Parameter and Output Adjustments:

  • Changed the gptModelVersion from a variable to a parameter in infra/main.bicep for better configurability. [1] [2]
  • Added logAnalyticsWorkspaceResourceName to the output in infra/deploy_ai_foundry.bicep to expose the log analytics workspace name.

Resource Configuration Updates:

  • Modified the applicationInsights resource to reference the new logAnalytics workspace in infra/deploy_ai_foundry.bicep.
  • Changed the value of the azureSearchIndexEntry resource from transcripts_index to pdf_index in infra/deploy_ai_foundry.bicep.

Template and Script Improvements:

  • Updated the baseUrl in infra/main.bicep to point to a new GitHub repository location for deployment scripts.
  • Added new deployment scripts for uploading files and creating indexes in infra/main.bicep to automate post-deployment tasks.

These changes collectively enhance the deployment process, improve resource management, and provide better logging and monitoring capabilities.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 56eb180 into dev Mar 18, 2025
3 of 4 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants