Merged
Conversation
…i version parameter name
Roopan-Microsoft
approved these changes
Mar 18, 2025
Contributor
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Key Changes:
Resource Management Enhancements:
logAnalyticsresource to theinfra/deploy_ai_foundry.bicepfile for better logging and monitoring.solutionLocation,baseUrl,keyVaultName, andidentityininfra/deploy_index_scripts.bicepto specify resource locations and identities.infra/deploy_post_deployment_scripts.bicepwith new parameters and resources for container app deployment and log analytics configuration.infra/deploy_upload_files_script.bicepto streamline data setup.Parameter and Output Adjustments:
gptModelVersionfrom a variable to a parameter ininfra/main.bicepfor better configurability. [1] [2]logAnalyticsWorkspaceResourceNameto the output ininfra/deploy_ai_foundry.bicepto expose the log analytics workspace name.Resource Configuration Updates:
applicationInsightsresource to reference the newlogAnalyticsworkspace ininfra/deploy_ai_foundry.bicep.azureSearchIndexEntryresource fromtranscripts_indextopdf_indexininfra/deploy_ai_foundry.bicep.Template and Script Improvements:
baseUrlininfra/main.bicepto point to a new GitHub repository location for deployment scripts.infra/main.bicepto automate post-deployment tasks.These changes collectively enhance the deployment process, improve resource management, and provide better logging and monitoring capabilities.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information