fix: DocGen- Save action triggers error when no changes are made to template title#385
Merged
Roopan-Microsoft merged 1 commit intomainfrom Apr 11, 2025
Merged
fix: DocGen- Save action triggers error when no changes are made to template title#385Roopan-Microsoft merged 1 commit intomainfrom
Roopan-Microsoft merged 1 commit intomainfrom
Conversation
Roopan-Microsoft
approved these changes
Apr 11, 2025
Contributor
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes changes to the
ChatHistoryListItemCellcomponent and its associated tests to improve user interaction and error handling. The most important changes include adding conditions to prevent actions during edit mode, updating button states based on title changes, and refining test cases to align with the new logic.Improvements to user interaction:
src/frontend/src/components/ChatHistory/ChatHistoryListItem.tsx: Added conditions to preventhandleSelectItemfrom being triggered during edit mode and to stop event propagation when editing. [1] [2]src/frontend/src/components/ChatHistory/ChatHistoryListItem.tsx: Updated thedisabledstate of the confirm button to include a check for whether the title has changed.Refinement of test cases:
src/frontend/src/components/ChatHistory/chatHistoryListItem.test.tsx: Removed outdated test cases that checked for error messages when confirming a new title, aligning with the updated logic. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information