Skip to content

fix: Fixed the code quality issue#802

Merged
Roopan-Microsoft merged 1 commit intodevfrom
psl-codeql
Apr 8, 2026
Merged

fix: Fixed the code quality issue#802
Roopan-Microsoft merged 1 commit intodevfrom
psl-codeql

Conversation

@Prekshith-Microsoft
Copy link
Copy Markdown
Contributor

@Prekshith-Microsoft Prekshith-Microsoft commented Apr 8, 2026

This pull request makes minor test improvements in src/tests/services/test_orchestrator.py by updating how the orchestrator module is referenced. Instead of directly importing and referencing orchestrator, the code now uses sys.modules["orchestrator"] to access module-level variables. This change improves test reliability, especially in scenarios where module state needs to be reset or checked dynamically. No production code is affected.

Most important changes:

Test reliability and module state management:

  • Replaced direct references to the orchestrator module with lookups via sys.modules["orchestrator"] for resetting the singleton and checking module-level attributes. This ensures that tests interact with the actual module instance Python is using, which is important when manipulating or inspecting module state. [1] [2] [3]## Purpose
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 5dccce1 into dev Apr 8, 2026
6 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants