Skip to content

ci: refactor notification email templates#462

Merged
Roopan-Microsoft merged 3 commits intomainfrom
psl-refactor-email
Mar 24, 2026
Merged

ci: refactor notification email templates#462
Roopan-Microsoft merged 3 commits intomainfrom
psl-refactor-email

Conversation

@Vamshi-Microsoft
Copy link
Contributor

Purpose

This pull request updates the deployment orchestrator and notification workflows to improve the handling and reporting of the cleanup stage, streamline input validation, and enhance notification emails with clearer status summaries and configuration details. The changes make the workflows more robust and the notifications more informative for recipients.

Workflow enhancements and cleanup handling:

  • Added a cleanup-deployment job to .github/workflows/deploy-orchestrator.yml, which runs after deployment and E2E tests, and passes its result to the notification job. The notification job now depends on cleanup completion.
  • The cleanup_result is now passed as an input to the notification workflow, and its value is used to determine and display the cleanup status in notification emails. (.github/workflows/deploy-orchestrator.ymlR132-L137, F63f414cL61R61)

Notification and reporting improvements:

  • Notification emails now include a status summary table for deployment, E2E tests, and cleanup, as well as a configuration label (e.g., "WAF + EXP") for better context. Email subjects have also been updated for clarity. [1] [2] [3]
  • Added steps in the notification workflow to determine and output the cleanup status and configuration label, which are then included in the email content.

Input validation and workflow simplification:

  • Removed the extensive input parameter validation step from the notification workflow, simplifying the workflow and reducing redundancy.
  • Made some workflow inputs optional with sensible defaults, such as making e2e_test_result not required and defaulting cleanup_result to 'skipped'. (.github/workflows/job-send-notification.ymlL36-R37, F63f414cL61R61)

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

@Roopan-Microsoft Roopan-Microsoft merged commit 6d78564 into main Mar 24, 2026
4 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.11.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants