fix: remove enableAnalyticalStorage on Cosmos DB account creation#588
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the infrastructure deployment templates for the solution accelerator, primarily to adjust Cosmos DB account configuration and (per the JSON template) introduce additional VM placement configurability and dependency ordering tweaks.
Changes:
- Removed the
enableAnalyticalStorageoverride from the Cosmos DB (Mongo) account deployment so the AVM module’s default behavior applies. - Updated
infra/main.jsonto add an optionalproximityPlacementGroupResourceIdparameter and wire it into the VM definition. - Reordered several
dependsOnarrays ininfra/main.json.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| infra/main.json | Updates generated ARM template: template hash, adds proximity placement group parameter/wiring, reorders some dependsOn entries, and removes the Cosmos DB enableAnalyticalStorage parameter pass-through. |
| infra/main.bicep | Removes enableAnalyticalStorage: true from the Cosmos DB AVM module invocation. |
Comments suppressed due to low confidence (2)
infra/main.json:42490
- Reordering entries inside a
dependsOnarray does not affect deployment sequencing in ARM/Bicep (the array is treated as a set of dependencies). If the goal is to fix an actual sequencing issue, this change is a no-op; consider either removing the reorder-only diff or adjusting the actual dependency list to match the required deployment graph.
infra/main.json:45693 - Reordering entries inside a
dependsOnarray does not affect deployment sequencing in ARM/Bicep (the array is treated as a set of dependencies). If the goal is to fix an actual sequencing issue, this change is a no-op; consider either removing the reorder-only diff or adjusting the actual dependency list to match the required deployment graph.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Prajwal-Microsoft
approved these changes
May 15, 2026
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request primarily updates the infrastructure deployment templates to improve resource configuration flexibility and correct resource dependency ordering. The most significant changes include adding support for proximity placement groups for virtual machines, reordering dependencies for private DNS zones, and removing the
enableAnalyticalStorageproperty from CosmosDB configurations.Infrastructure Configuration Improvements
proximityPlacementGroupResourceIdto support specifying a proximity placement group for virtual machines, and updated the VM resource configuration to use this parameter if provided. [1] [2]Resource Dependency Corrections
dependsOnarrays to ensure correct deployment sequencing. [1] [2] [3]CosmosDB Configuration Changes
enableAnalyticalStorageproperty from the CosmosDB account configuration in both the Bicep and generated JSON templates, likely to align with updated requirements or to avoid unnecessary features. [1] [2]Other
templateHashinmain.jsonto reflect the changes in the template.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information