Skip to content

fix: remove enableAnalyticalStorage on Cosmos DB account creation#588

Merged
Prajwal-Microsoft merged 1 commit into
mainfrom
psl-sw/fix-cosmos-analytical-storage
May 15, 2026
Merged

fix: remove enableAnalyticalStorage on Cosmos DB account creation#588
Prajwal-Microsoft merged 1 commit into
mainfrom
psl-sw/fix-cosmos-analytical-storage

Conversation

@Shreyas-Microsoft
Copy link
Copy Markdown
Collaborator

Purpose

This pull request primarily updates the infrastructure deployment templates to improve resource configuration flexibility and correct resource dependency ordering. The most significant changes include adding support for proximity placement groups for virtual machines, reordering dependencies for private DNS zones, and removing the enableAnalyticalStorage property from CosmosDB configurations.

Infrastructure Configuration Improvements

  • Added a new parameter proximityPlacementGroupResourceId to support specifying a proximity placement group for virtual machines, and updated the VM resource configuration to use this parameter if provided. [1] [2]

Resource Dependency Corrections

  • Corrected the order of private DNS zone dependencies in several resource dependsOn arrays to ensure correct deployment sequencing. [1] [2] [3]

CosmosDB Configuration Changes

  • Removed the enableAnalyticalStorage property from the CosmosDB account configuration in both the Bicep and generated JSON templates, likely to align with updated requirements or to avoid unnecessary features. [1] [2]

Other

  • Updated the Bicep-generated templateHash in main.json to reflect the changes in the template.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the infrastructure deployment templates for the solution accelerator, primarily to adjust Cosmos DB account configuration and (per the JSON template) introduce additional VM placement configurability and dependency ordering tweaks.

Changes:

  • Removed the enableAnalyticalStorage override from the Cosmos DB (Mongo) account deployment so the AVM module’s default behavior applies.
  • Updated infra/main.json to add an optional proximityPlacementGroupResourceId parameter and wire it into the VM definition.
  • Reordered several dependsOn arrays in infra/main.json.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
infra/main.json Updates generated ARM template: template hash, adds proximity placement group parameter/wiring, reorders some dependsOn entries, and removes the Cosmos DB enableAnalyticalStorage parameter pass-through.
infra/main.bicep Removes enableAnalyticalStorage: true from the Cosmos DB AVM module invocation.
Comments suppressed due to low confidence (2)

infra/main.json:42490

  • Reordering entries inside a dependsOn array does not affect deployment sequencing in ARM/Bicep (the array is treated as a set of dependencies). If the goal is to fix an actual sequencing issue, this change is a no-op; consider either removing the reorder-only diff or adjusting the actual dependency list to match the required deployment graph.
    infra/main.json:45693
  • Reordering entries inside a dependsOn array does not affect deployment sequencing in ARM/Bicep (the array is treated as a set of dependencies). If the goal is to fix an actual sequencing issue, this change is a no-op; consider either removing the reorder-only diff or adjusting the actual dependency list to match the required deployment graph.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread infra/main.json
Comment thread infra/main.json
@Prajwal-Microsoft Prajwal-Microsoft merged commit d75db01 into main May 15, 2026
10 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 2.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants