feat - LSP data layer + confirmationService skeleton （Auto-approve Part 1 )#132
Open
xinyi-gong wants to merge 2 commits intofeature/auto-approvefrom
Open
feat - LSP data layer + confirmationService skeleton （Auto-approve Part 1 )#132xinyi-gong wants to merge 2 commits intofeature/auto-approvefrom
xinyi-gong wants to merge 2 commits intofeature/auto-approvefrom
Conversation
xinyi-gong
force-pushed
the
tori/auto-approve-task-1
branch
from
43ee7e3 to
320cec3
Compare
jdneo
reviewed
Apr 30, 2026
| * Evaluates whether a tool confirmation request can be auto-approved. | ||
| * Each implementation handles a specific category of tool (terminal, file operations, MCP, etc.). | ||
| */ | ||
| public interface ConfirmationHandler { |
Member
There was a problem hiding this comment.
Maybe move this class to core bundle?
| * request should be auto-approved or shown to the user. Currently a no-op skeleton that | ||
| * always requires confirmation; concrete logic will be added in subsequent sub-tasks. | ||
| */ | ||
| public class ConfirmationService { |
Member
There was a problem hiding this comment.
Maybe move this class to core bundle?
| * @param params the confirmation request parameters from CLS | ||
| * @return the confirmation result (currently always {@link ConfirmationResult#NEEDS_CONFIRMATION}) | ||
| */ | ||
| public ConfirmationResult evaluate(InvokeClientToolConfirmationParams params) { |
Member
There was a problem hiding this comment.
How will this class looks like ultimately? (I'm trying to understand why it is a standalone class, not just a utility)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.