Skip to content

Fix ui deadlock #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xinyi-gong merged 2 commits into from
May 13, 2026
Merged

Fix ui deadlock #182

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
567e669
fix ui deadlock and infinite retry loop on 402 quota error
xinyi-gong May 13, 2026
74daf04
revert fix for 402 quota usage
xinyi-gong May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...t.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/services/ModelService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;

import org.apache.commons.lang3.StringUtils;
Expand Down Expand Up @@ -348,7 +349,11 @@ public void setActiveModel(String modelName) {
// Persist using the composite key for proper identification
UserPreference preference = getUserPreference();
preference.setChatModel(compositeKey);
persistUserPreference();
// Persist asynchronously to avoid deadlock: persistUserPreference() calls
// persistence().get() which blocks waiting for the LSP listener thread.
// If called on the UI thread while the listener is in syncExec, both threads
// deadlock.
CompletableFuture.runAsync(this::persistUserPreference);
Comment thread
xinyi-gong marked this conversation as resolved.

// Update observable
ensureRealm(() -> activeModelObservable.setValue(model));
Expand Down
Loading