Conversation
* fix the bug Not properly disposed SWT resource. * fix the bug that failed to install terminal bundle.
- Since the new CLS will separate binaries for different platforms, we need to update the copy-binaries.js script to copy the binaries from the new paths. - --force is used when installing npm packages to force npm download packages which does not apply to the current platform.
This fixes regression from commit 83214c1 reported at eclipse-copilot/eclipse-copilot#45. The main point is that the values that need to be **stored** in the configuration scope should be **read** via `Platform.getPreferencesService()`. The `IPreferencesService` includes by default (no scopes given) **all** scopes (also config, instance and product relevant here). The `CopilotPreferenceInitializer` doesn't need to set any values in the configuration scope, if nothing is set, defaults hard-coded in the code can be used used and set to the instance defaults, if config scope has custom value, this will be used for the instance scope as default. This way the `GeneralPreferencesPage` will always show the "right" value for reading from the workspace scope and for writing it will write to both workspace and config scope. Note also that this patch fixes the plugin id used to store preferences, it reverts the code to the original state where the preferences from `com.microsoft.copilot.eclipse.ui` bundle were used. To verify the fix with product customization, start Eclipse with extra application argument `-pluginCustomization /tmp/pluginCustomization.ini` and the file content like below: ``` com.microsoft.copilot.eclipse.ui/autoShowWhatsNew=false com.microsoft.copilot.eclipse.ui/lastUsedCopilotPluginVersion=0.11 com.microsoft.copilot.eclipse.ui/copilotQuickStartVersion=1 ``` That should not show any "what's new" dialog. Fixes eclipse-copilot/eclipse-copilot#45
* fix - Get the chatset by file
LSPEclipseUtils returns different URI schemes with different API's. Example toUri(File file) returns file:///C: scheme where as toUri(@nullable IDocument document) returns file:/C: scheme. But in both cases underlying file resource is same. So we introduce URI comparison as secondary approach. Primary comparison approach remains the same. see microsoft/GitHub-Copilot-for-Eclipse#47
Fix URI comparison for similar URI schemes.
…ar to WorkingSetBar (#1617) Compare editors and file editors no longer auto-open when Copilot applies changes, preventing focus stealing. Users must click a file in the WorkingSetBar to view diffs. Also renames FileChangeSummaryBar, FileChangeSummaryHandler, and all related methods to use WorkingSet naming.
…izing token usage (#1623)
* add nes related telemetry * resolve comments * resolve missing import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.