feat- Unify thinking block title under a single "Thinking" label and change cancel timing#200
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the chat thinking block UI to consolidate the visible thinking status text around a single Thinking label, addressing rendering issues from #192.
Changes:
- Replaces separate in-progress/completed/cancelled thinking message keys with one
thinking_title. - Updates
ThinkingBlockcompletion/cancellation behavior to stop changing the title per state. - Adjusts
ThinkingTurnWidgetto call the simplifiedshowCompleted()API.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ThinkingTurnWidget.java |
Uses the new no-arg completion API and still handles async thinking title generation. |
ThinkingBlock.java |
Updates thinking block state/title behavior and exposes title-setting helper. |
messages.properties |
Consolidates thinking title strings into one Thinking message. |
Messages.java |
Updates NLS fields to match the consolidated message key. |
Comments suppressed due to low confidence (1)
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/ThinkingTurnWidget.java:104
- A sealed block remains non-finalized until this async title response runs. During that window,
onChatMessageCancelled()can still callshowCancelled()because SEALED is not considered finalized, so pressing Stop after the thinking stream has ended can still mark the already-complete thinking block as cancelled.
target.showCompleted();
jdneo
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #192



