Skip to content

feat- Unify thinking block title under a single "Thinking" label and change cancel timing#200

Merged
jdneo merged 4 commits into
mainfrom
tori/thinking-title
May 15, 2026
Merged

feat- Unify thinking block title under a single "Thinking" label and change cancel timing#200
jdneo merged 4 commits into
mainfrom
tori/thinking-title

Conversation

@xinyi-gong
Copy link
Copy Markdown
Member

resolve #192
image
image
image
image

Copilot AI review requested due to automatic review settings May 15, 2026 02:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the chat thinking block UI to consolidate the visible thinking status text around a single Thinking label, addressing rendering issues from #192.

Changes:

  • Replaces separate in-progress/completed/cancelled thinking message keys with one thinking_title.
  • Updates ThinkingBlock completion/cancellation behavior to stop changing the title per state.
  • Adjusts ThinkingTurnWidget to call the simplified showCompleted() API.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
ThinkingTurnWidget.java Uses the new no-arg completion API and still handles async thinking title generation.
ThinkingBlock.java Updates thinking block state/title behavior and exposes title-setting helper.
messages.properties Consolidates thinking title strings into one Thinking message.
Messages.java Updates NLS fields to match the consolidated message key.
Comments suppressed due to low confidence (1)

com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/ThinkingTurnWidget.java:104

  • A sealed block remains non-finalized until this async title response runs. During that window, onChatMessageCancelled() can still call showCancelled() because SEALED is not considered finalized, so pressing Stop after the thinking stream has ended can still mark the already-complete thinking block as cancelled.
          target.showCompleted();

@xinyi-gong xinyi-gong changed the title feat- Unify thinking block title under a single "Thinking" label feat- Unify thinking block title under a single "Thinking" label and change cancel timming May 15, 2026
@xinyi-gong xinyi-gong changed the title feat- Unify thinking block title under a single "Thinking" label and change cancel timming feat- Unify thinking block title under a single "Thinking" label and change cancel timing May 15, 2026
@jdneo jdneo merged commit 3d617b2 into main May 15, 2026
4 checks passed
@jdneo jdneo deleted the tori/thinking-title branch May 15, 2026 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rendering issues for thinking block

3 participants