Fix macOS CI failure by aligning formatting fallback with Eclipse editor preferences#273
Closed
Copilot wants to merge 3 commits into
Closed
Fix macOS CI failure by aligning formatting fallback with Eclipse editor preferences#273Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job build (macos-latest)
Fix macOS CI failure by aligning formatting fallback with Eclipse editor preferences
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build (macos-latest)was failing due toFormatOptionProviderTestsexpecting editor-derived indentation defaults, while production fallback logic returned hardcoded values for unknown/no-extension files. This change makes fallback behavior preference-driven and updates tests to assert the same source of truth.Problem
FormatOptionProviderdefaulted to hardcodedspace + tabSize=4when no language-specific formatter was available, diverging from Eclipse editor preference behavior on macOS.Production change
FormatOptionProvider, unknown language and no-extension paths now resolve indentation fromorg.eclipse.ui.editorspreferences:spacesForTabstabWidthTest alignment
FormatOptionProviderTestsnow computes expected values from the same Eclipse preference service instead of asserting hardcoded defaults for unknown/no-extension cases.