Remove hard dependency on wininet.dll from mip_ClientTelemetry#1428
Merged
Conversation
|
Just out of curiosity, is any of our building processes ever defining |
AlvaroPalmaAsteMicrosoft
approved these changes
Apr 24, 2026
AlvaroPalmaAsteMicrosoft
requested changes
Apr 29, 2026
AlvaroPalmaAsteMicrosoft
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK links against wininet.lib, creating a load-time dependency on wininet.dll. When customers disable WinINet on their servers, the DLL fails to load entirely, breaking MIP SDK usage even though no WinINet functions are actually called.
This change Removes the hard link-time dependency on wininet.dll from the mip_ClientTelemetry.dll. The MIP SDK never uses the built-in WinINet HTTP client it always provides its own IHttpClient implementation so this dependency is unnecessary and causes failures for customers who disable WinINet on their servers.