Remove stale MSBuild project entries#1444
Merged
bmehta001 merged 4 commits intoMay 22, 2026
Merged
Conversation
Clean project and filter wiring that points at removed or generated files so Visual Studio metadata matches the files carried in the repo. Files changed: - Solutions/Clienttelemetry/Clienttelemetry.vcxitems - examples/cpp project and filter files - lib/pal and lib/tracing shared item files - tests/googletest filter metadata - third_party/Solutions/zlib/vc14/zlibvc.vcxproj - tools/ports/mstelemetry/v142-build.patch Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The commented PackageCertificateKeyFile and PackageCertificateThumbprint lines document how to enable Appx package signing if a developer provides a TestApp.pfx. Restore them so the sample retains its re-enablement instructions; only the unconditional None Include for TestApp.pfx (which referenced a missing file) needed to go. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up Visual Studio/MSBuild project and filter metadata by removing references to files that no longer exist in the repo and correcting a few stale relative paths, improving Windows build hygiene and solution usability.
Changes:
- Removed stale zlib header entries (e.g., infblock.h/infcodes.h/infutil.h) from MSBuild project metadata.
- Fixed stale/incorrect relative paths in sample project references, tracing SHA1 shared-items references, and the gtest filters entry.
- Pruned stale entries from various
.filters/.vcxitemsfiles to better match the current repository contents.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/ports/mstelemetry/v142-build.patch | Drops removed zlib header references from the v142 port patch metadata. |
| third_party/Solutions/zlib/vc14/zlibvc.vcxproj | Removes zlib includes for headers not present in the repo. |
| tests/googletest/googletest/msvc/gtest.vcxproj.filters | Updates gtest-all.cc filter path to match the referenced source location. |
| Solutions/Clienttelemetry/Clienttelemetry.vcxitems.filters | Removes stale shared-items filter entries for headers no longer present. |
| Solutions/Clienttelemetry/Clienttelemetry.vcxitems | Removes stale shared-items entries for headers no longer present. |
| lib/tracing/api/tracing-api.vcxitems | Fixes relative paths for bundled sha1 sources/headers. |
| lib/pal/universal/universal.vcxitems.filters | Removes conditional UTC module filter entries (optional submodule integration). |
| lib/pal/desktop/desktop.vcxitems.filters | Removes conditional UTC module filter entries (optional submodule integration). |
| examples/cpp/SampleCppUWP/SampleCppUWP.vcxproj.filters | Removes stale TestApp.pfx entry from filters. |
| examples/cpp/SampleCppUWP/SampleCppUWP.vcxproj | Removes stale TestApp.pfx item entry from the project. |
| examples/cpp/SampleCpp/SampleCpp.vcxproj | Fixes stale relative paths for referenced projects (win32-lib/sqlite). |
| examples/cpp/EventSender/EventSender.vcxproj.filters | Removes stale/non-project items from filters. |
| examples/cpp/EventSender/EventSender.vcxproj | Fixes stale relative paths for referenced projects (win32-lib/sqlite). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The matching desktop.vcxitems and universal.vcxitems still include the UTC module sources via Condition="Exists(...)". Removing the parallel entries from the .filters files would orphan those sources in Visual Studio Solution Explorer when the lib/modules submodule is present. Restore the conditional ItemGroups so solution organization stays correct when the optional module exists. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
FuncTests.vcxproj uses $(ProjectDir)..\..\lib\modules\signals\tests\functests\SignalsFuncTests.cpp while the parallel filter entry was missing the $(ProjectDir) prefix, so when the signals submodule is present Visual Studio cannot associate the source file with the Source Files filter. Align the filter Include with the project Include. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
baijumeswani
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation