CodeQL SM02383: js/incomplete-sanitization#1455
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses the CodeQL finding SM02383 (js/incomplete-sanitization) by improving how the build version string is normalized after reading Solutions/version.txt, ensuring trailing line endings/whitespace don’t propagate into generated version outputs.
Changes:
- Replace single
"\n"removal withString.prototype.trim()in the Windows Script Host version generator. - Apply the same
trim()normalization in the Node-based version generator for consistency.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/version.js | Uses trim() to fully remove surrounding whitespace/line endings from the version tag before further processing. |
| tools/version-node.js | Uses trim() to normalize the version tag read from disk before placeholder replacement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ThomsonTan
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.