Remove stale MSBuild references#1463
Merged
bmehta001 merged 1 commit intoJun 5, 2026
Merged
Conversation
Split the stale Visual Studio wiring cleanup into a smaller review slice. Remove project and filter entries for files that no longer exist, and keep platform toolset fallback behavior current for VS 2026 without forcing future toolsets to older defaults. Files changed: Solutions/before.targets, Solutions/build.MIP.props, Visual Studio project and filter files Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up Windows/MSBuild project metadata by removing references to files that no longer exist and modernizing the Visual Studio toolset fallback logic so newer VS versions don’t get forced into an older toolset mapping.
Changes:
- Removed stale
<ClInclude>/ filter entries for deleted test and sample files. - Updated MSBuild toolset fallback logic to map
VisualStudioVersion >= 18.0tov145, while keeping explicit mappings for older VS versions. - Avoided relying on
DefaultPlatformToolsetinbefore.targets(imported too early), and used version-based mapping there instead.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unittests/UnitTests.vcxproj | Removes a stale sanitizer test file entry from the unit test project. |
| tests/functests/FuncTests.vcxproj.filters | Removes a stale filter entry for a deleted mock header. |
| tests/functests/FuncTests.vcxproj | Removes a stale include entry for a deleted mock header. |
| Solutions/build.MIP.props | Updates toolset selection to prefer DefaultPlatformToolset and adds explicit VS-version mappings up through VS 18.0. |
| Solutions/before.targets | Reworks toolset fallback mapping using VisualStudioVersion comparisons (including VS 18.0 → v145). |
| lib/shared/Shared.vcxitems.filters | Removes a stale shared-items filter entry for a deleted header. |
| lib/shared/Shared.vcxitems | Removes a stale shared-items include entry for a deleted header. |
| examples/cpp/SampleCppMini/SampleCppMini.vcxproj.filters | Removes a stale filter entry for a missing targetver.h in the sample. |
| examples/cpp/SampleCppMini/SampleCppMini.vcxproj | Removes a stale project include entry for a missing targetver.h in the sample. |
| examples/cpp/SampleCpp/SampleCpp.vcxproj.filters | Removes a stale filter entry for a missing targetver.h in the sample. |
| examples/cpp/SampleCpp/SampleCpp.vcxproj | Removes a stale project include entry for a missing targetver.h in the sample. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lkarra2
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is split out of #1416 to keep the review surface small and focused.
Changes:
Validation performed locally:
git diff --checkVisualStudioVersion=18.0resolves tov145