Re-add the Boost.Filesystem fallback #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wravery
commented
Dec 6, 2020
| find_package(Threads MODULE REQUIRED) | ||
|
|
||
| find_package(pegtl 3.0.0 QUIET CONFIG) | ||
| find_package(pegtl 3.0.1 QUIET CONFIG) |
Contributor
Author
There was a problem hiding this comment.
3.0.1 hasn't been released yet for PEGTL, but the version has already been updated in preparation for the next release. Since we want to pick up the version with the std::filesystem fallback logic from the sub-module instead of a 3.0.0 release package, it makes sense to bump the requirement up here too.
Users of vcpkg should see a version number of 3.0.0 in vcpkg once that port is done, but internally PEGTL will be using version 3.0.1 because I'll use a commit ID that includes the std::filesystem fallbacks.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After figuring out how to auto-detect
std::filesystemsupport in PEGTL, I ported some of that CMake logic to this project. Now that they both have this capability, I can resume updating the vcpkg ports.