Skip to content

Conversation

@wravery
Copy link
Contributor

@wravery wravery commented Jan 26, 2019

Breaking API change, requires bumping the major version for the next release. Might want to release a minor version update with the subscription argument filtering and other bug fixes first unless either of those introduces a breaking change.

@wravery
Copy link
Contributor Author

wravery commented Jan 26, 2019

I think each of those might require a breaking API change. To bubble up field errors I'll need to either change the return type of Object::resolve or add an out-param to append to the errors collection in addition to returning the field value, and it should also be done with a future.

@wravery
Copy link
Contributor Author

wravery commented Jan 26, 2019

The subscription argument filtering might not introduce a breaking change from the 1.0.* releases. I think I can get by with another deliver override which passes an argument comparator callback. The deliver override I added in #26 can pass a lambda with the current exact match logic for backwards compatibility and default comparisons.

@wravery wravery merged commit c557f18 into microsoft:master Jan 27, 2019
@wravery wravery deleted the ast_by_value branch January 27, 2019 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant