Support for Resource Owner Password Credentials or Password grant #1625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
barcharcraz
suggested changes
Aug 18, 2021
barcharcraz
left a comment
barcharcraz
left a comment
There was a problem hiding this comment.
The changes here seem unrelated to resource owner passeword credentials or grants? They look like mingw related changes? did you use the wrong branch creating this PR?
Author
|
I didn't know that my newer changes could affect my PR. I thought my PR was static. So, I moved the MinGW changes away from the main branch, so the password grant changes are only there. If you're still interested in the MinGW related changes I could open another PR, but it still suffers from some issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, there was no implementation for any password grant in oauth2_config; there was discussion of it in #151 but it nothing came of it. So I implemented it myself. What do you think? Let me know of any issues and if it can merge. Thanks