Random-access iterators over IVector/IVectorView #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The built-in iterators for IVector and IVectorView (and more generally anything that has a GetAt method) now support random-access operations. They do not meet all the requirements of a random-access iterator, most notably: * `reference` is not `value_type&` or `value_type const&`. * `operator->` is not supported. Design notes: * The `value_type` had been misdeclared as `T` (e.g. `IVector<Something>`) rather than the element type (`Something`). * The `reference` is not actually a reference because the return value of `operator*` must be convertible to `reference`. * The element index is unsigned so that the relational operators like `<` produce correct results on large containers. * The `difference_type` is `ptrdiff_t` so that `b-a` and related operations work on large containers. * Return types for iterator operations are explicit to ensure they conform to iterator requirements. * We now rely on `std::reverse_iterator` to implement our reverse iterator.
kennykerr
reviewed
Apr 8, 2020
kennykerr
approved these changes
Apr 8, 2020
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The built-in iterators for IVector and IVectorView (and more generally anything that has a GetAt method) now support random-access operations. They do not meet all the requirements of a random-access iterator, most notably:
referenceis notvalue_type&orvalue_type const&.operator->is not supported.Design notes:
value_typehad been misdeclared asT(e.g.IVector<Something>) rather than the element type (Something).referenceis not actually a reference because the return value ofoperator*must be convertible toreference.<produce correct results on large containers.difference_typeisptrdiff_tso thatb-aand related operations work on large containers.std::reverse_iteratorto implement our reverse iterator.