Skip to content

make_self respects static_lifetime #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kennykerr merged 1 commit into from
Apr 16, 2020
Merged

make_self respects static_lifetime #589

kennykerr merged 1 commit into from
Apr 16, 2020

Conversation

@oldnewthing
Copy link
Member

@oldnewthing oldnewthing commented Apr 16, 2020

make_self now respects static_lifetime. I suspect this was overlooked when static_lifetime was introduced.

@kennykerr
Copy link
Collaborator

kennykerr commented Apr 16, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 16, 2020

No pipelines are associated with this pull request.

kennykerr
kennykerr approved these changes Apr 16, 2020
View reviewed changes
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennykerr kennykerr merged commit 7b11196 into microsoft:master Apr 16, 2020
@oldnewthing oldnewthing deleted the make_self_static_lifetime branch April 16, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennykerr kennykerr kennykerr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oldnewthing @kennykerr