Skip to content

Conversation

@Scottj1s
Copy link
Member

fixes #593

@kennykerr
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@kennykerr kennykerr requested a review from jlaanstra April 20, 2020 14:19
@riverar
Copy link

riverar commented Apr 20, 2020

In the case of a simple console app that simply:

  • Adds the NuGet package
  • Has a single winrt::init_apartment(); call

Projection headers get generated. As far as I know, in the above case, none of these are true (from README):

  • NuGet package references containing winmd files
  • Other project references producing winmd files
  • Raw winmd file references

Which means this part of the README isn't true (emphasis mine):

[...] For any winmd file discovered above, C++/WinRT creates reference (consuming) projection headers.

Am I missing something?

@Scottj1s
Copy link
Member Author

In the case of a simple console app that simply:

  • Adds the NuGet package
  • Has a single winrt::init_apartment(); call

Projection headers get generated. As far as I know, in the above case, none of these are true (from README):

  • NuGet package references containing winmd files
  • Other project references producing winmd files
  • Raw winmd file references

Which means this part of the README isn't true (emphasis mine):

[...] For any winmd file discovered above, C++/WinRT creates reference (consuming) projection headers.

Am I missing something?

The first bullet is true:

  • Platform winmd files in the SDK (both MSI and NuGet)

These are not "referenced" directly by the project (so I'm avoiding that term), but are still "discovered" and processed by cppwinrt.exe to produced headers.

@riverar
Copy link

riverar commented Apr 20, 2020

Oh got it! The existence of the platform winmd files is the trigger.

@Scottj1s Scottj1s merged commit bb6fd22 into master Apr 20, 2020
@Scottj1s Scottj1s deleted the scottj1s/nuget_additional_metadata branch April 20, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$(GeneratedFilesDir) not added to AdditionalIncludeDirectories if AdditionalIncludeDirectories is explicitly defined

5 participants