Improve performance of make_factory with static_lifetime #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code constructed a new object each time, even though only the first call will actually need the constructed object. The second and subsequent calls just throw the object away and return the existing object. Construct the object only if we have a reasonable chance of actually using it. This is a big win for static-lifetime objects that are expensive to construct.
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code constructed a new object each time, even though only the first call will actually need the constructed object. The second and subsequent calls just throw the object away and return the existing object.
Construct the object only if we have a reasonable chance of actually using it. This is a big win for static-lifetime objects that are expensive to construct.