Skip to content

make progress_token::operator() const so it can be captured by lambdas #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennykerr merged 2 commits into from
Jun 29, 2020
Merged

make progress_token::operator() const so it can be captured by lambdas #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c44c583
make progress_token::operator() const so it can be captured by lambdas
oldnewthing Jun 28, 2020
7feffa4
Merge branch 'master' into progress
kennykerr Jun 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion strings/base_coroutine_foundation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ namespace winrt::impl
return *this;
}

void operator()(Progress const& result)
void operator()(Progress const& result) const
{
m_promise->set_progress(result);
}
Expand Down
8 changes: 6 additions & 2 deletions test/test/async_progress.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,12 @@ namespace
IAsyncOperationWithProgress<int, int> Operation(HANDLE event)
{
co_await resume_on_signal(event);
auto progress = co_await get_progress_token();
progress(123);

// Invoke from a lambda to ensure that operator() is const.
[progress = co_await get_progress_token()]()
{
progress(123);
}();
co_return 1;
}

Expand Down