Skip to content

add [[nodiscard]] to weak_ref agile_ref get() methods to avoid incorrect use #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kennykerr merged 1 commit into from
Aug 5, 2020
Merged

add [[nodiscard]] to weak_ref agile_ref get() methods to avoid incorrect use #719

kennykerr merged 1 commit into from
Aug 5, 2020

Conversation

@ChrisGuzak
Copy link
Member

@ChrisGuzak ChrisGuzak commented Aug 5, 2020 •
edited by kennykerr
Loading

Fixes #718

@ChrisGuzak ChrisGuzak mentioned this pull request Aug 5, 2020
Closed
@kennykerr
Copy link
Collaborator

kennykerr commented Aug 5, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 5, 2020

No pipelines are associated with this pull request.

kennykerr
kennykerr approved these changes Aug 5, 2020
View reviewed changes
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennykerr kennykerr merged commit af6c70e into microsoft:master Aug 5, 2020
@ChrisGuzak ChrisGuzak deleted the user/chrisg/nodiscard_weak_agile branch August 6, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennykerr kennykerr kennykerr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

should winrt::weak_ref<>::get() use [[nodiscard]]?

2 participants

@ChrisGuzak @kennykerr