Use instrumented vectors/maps in tests to force race conditions more efficiently #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of running 100,000 iterations hoping to hit a race condition, use an instrumented vector/map that lets us inject delays into specific operations, and which detects concurrency violations. This allows us to force specific race conditions rather than waiting for them to happen. This reduces the running time of the multi* tests from 80 seconds to 1.5 seconds, as measured on a Surface Pro 5 (dual Core-i5 7300U). You can flip the #if at the top of multi_threaded_vector.cpp and multi_threaded_map.cpp to force the test to use a single-threaded collection and observe that the race conditions are hit.
kennykerr
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of running 100,000 iterations hoping to hit a race condition, use an instrumented vector/map that lets us inject delays into specific operations, and which detects concurrency violations. This allows us to force specific race conditions rather than waiting for them to happen.
This reduces the running time of the multi* tests from 80 seconds to 1.5 seconds, as measured on a Surface Pro 5 (dual Core-i5 7300U).
You can flip the #if at the top of multi_threaded_vector.cpp and multi_threaded_map.cpp to force the test to use a single-threaded collection and observe that the race conditions are hit.