-
Notifications
You must be signed in to change notification settings - Fork 262
Revert nuget to 2.0.200609.3 #793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This effectively blocks my team from taking newer versions as this reverts a few necessary fixes /cc @asklar. If we no longer want to maintain the build support, can we ship the build support separately so I can fork build support without needing to fork the binaries? |
|
I don't think we can easily make further packaging changes as VS is intending to consume the package as-is, but you are free to fork the build support without needing any change from cppwinrt. You can also just grab |
|
I'm lacking some context here... What's the issue that this is unblocking/what is broken for the OS? |
|
@asklar this reverts also your fix for the target ordering related to accessing pdb's. |
|
This is about reverting to a stable baseline. Since then, a few people have contributed tweaks but that resulted in a stream of regressions. I'll add you to an internal thread. |
This reverts commit cfda436.
Revert "Nuget 2.0.200609.3 (microsoft#793)"
This reverts commit cfda436.
This reverts commit cfda436.
* Revert "Nuget 2.0.200609.3 (#793)" This reverts commit cfda436. * Remove the use of TargetPlatformWinMDLocation as the C++ build targets put a problematic path in it. * MSBuild only resolves refs for TargetPlatformIdentifier=UAP. C++/WinRT does it for non-UAP projects. * Use Copy Local in the property name instead of Private.
This is the last stable version that was ingested into the OS.