Skip to content

Conversation

@kennykerr
Copy link
Collaborator

This is the last stable version that was ingested into the OS.

@kennykerr kennykerr merged commit cfda436 into master Nov 13, 2020
@kennykerr kennykerr deleted the nuget branch November 13, 2020 18:57
@jlaanstra
Copy link
Contributor

This effectively blocks my team from taking newer versions as this reverts a few necessary fixes /cc @asklar. If we no longer want to maintain the build support, can we ship the build support separately so I can fork build support without needing to fork the binaries?

@kennykerr
Copy link
Collaborator Author

I don't think we can easily make further packaging changes as VS is intending to consume the package as-is, but you are free to fork the build support without needing any change from cppwinrt. You can also just grab cppwinrt.exe (ignore everything else) and use your own build support. Then you're entirely independent and only rely on cppwinrt for code gen (as it should be).

@asklar
Copy link
Member

asklar commented Nov 13, 2020

I'm lacking some context here... What's the issue that this is unblocking/what is broken for the OS?

@jlaanstra
Copy link
Contributor

@asklar this reverts also your fix for the target ordering related to accessing pdb's.

@kennykerr
Copy link
Collaborator Author

This is about reverting to a stable baseline. Since then, a few people have contributed tweaks but that resulted in a stream of regressions. I'll add you to an internal thread.

jlaanstra added a commit that referenced this pull request Nov 13, 2020
jlaanstra added a commit to jlaanstra/cppwinrt that referenced this pull request Nov 13, 2020
jlaanstra added a commit that referenced this pull request Nov 16, 2020
jlaanstra added a commit that referenced this pull request Dec 11, 2020
jlaanstra added a commit that referenced this pull request Dec 15, 2020
* Revert "Nuget 2.0.200609.3 (#793)"

This reverts commit cfda436.

* Remove the use of TargetPlatformWinMDLocation as the C++ build targets put a problematic path in it.

* MSBuild only resolves refs for TargetPlatformIdentifier=UAP. C++/WinRT does it for non-UAP projects.

* Use Copy Local in the property name instead of Private.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants