Use separate vsixmanifest files for Component and Standalone deployments #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
BenJKuhn
reviewed
Apr 21, 2021
| <Tags>WinRT, C++, cppwinrt, native</Tags> | ||
| </Metadata> | ||
| <Installation AllUsers="true"> | ||
| <InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[15.0,17.0)" /> |
Member
There was a problem hiding this comment.
just curious, will this line, as written, block on 17.1, 17.2, etc.? If so, is that intentional?
Member
Author
There was a problem hiding this comment.
This line will actually block starting on 17.0 and up. I didn't write this line originally, but I imagine it was intentional, with the thinking being that we'd want to actually test this extension on 17.0 first. This seems like a good decision, especially in light of some upcoming changes to VS 17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to remove the dependency on
Microsoft.VisualStudio.Component.CoreEditorfor the "Component" VSIX, but want to keep this dependency for the "Standalone" VSIX.This change forks the
source.extension.vsixmanifestfile into "Component" and "Standalone" flavors.