-
Notifications
You must be signed in to change notification settings - Fork 262
Add #pragma once in addition to header guard. #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I vaguely recall having to use |
kennykerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to accept this change, but its possible this will break in some obscure way in the OS build. If that happens, its simple enough to revert.
|
Let me send mail to see whatI can find out, before merging. |
kennykerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like we don't have a compelling reason to take this change. There's no data that this improves performance and some risk that this breaks the OS build.
|
There is at least the argument of consistency that makes it worth it, even if there is no large perf benefit? Especially given that the stl follows the same pattern? |
|
I don't mind the change itself - I'm just concerned about the fallout from the OS build - ChrisG's comment reminded me that I'd seen that very issue in the OS build before when using pragma once with C++/WinRT. I don't know if it still exists but it would burn a Windows build finding out. I'm happy if you want to do that finding out though. 😉 |
|
Let's find out :). Worst case I learn something new. |
Fixes #945. Given that the component headers already use this I don't think this would break C++/WinRT compatibility with compilers that don't support this (technically it's non-standard).
Question is if we need to keep the open file guard?