Skip to content

Improve diagnostics when implements<> is used incorectly #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennykerr merged 3 commits into from
Jun 14, 2021
Merged

Improve diagnostics when implements<> is used incorectly #959

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2bd72e
Improve diagnostics when implements<> is used incorectly
oldnewthing Jun 13, 2021
b4ad42c
Another common error is forgetting to derive from implements at all
oldnewthing Jun 13, 2021
ec6922e
Merge branch 'master' into implements_error
kennykerr Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions strings/base_implements.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1437,6 +1437,7 @@ WINRT_EXPORT namespace winrt

hstring GetRuntimeClassName() const override
{
static_assert(std::is_base_of_v<implements_type, D>, "Class must derive from implements<> or ClassT<> where the first template parameter is the derived class name, e.g. struct D : implements<D, ...>");
return impl::runtime_class_name<typename impl::implements_default_interface<D>::type>::get();
}

Expand Down