fix: skip gha prompt when explicitly set

[karlhorky]

alternative to #173

• add --no-gha to the CLI
• treat explicit --gha / --no-gha as answered so the GitHub Actions prompt is skipped
• use a numeric initial index for the language select prompt so skipped --lang js resolves correctly in the non-quiet path
• add integration coverage for explicit GHA flags in quiet and non-quiet flows

Context

This PR is an alternative to #173 for the remaining --gha / --no-gha prompt-skipping gap from the linked review comment.

[karlhorky]

@Skn0tt this apparently was broken with enquirer for longer, and was causing test failures:

import enquirer from 'enquirer';
const { prompt } = enquirer;

console.log(await prompt([{
  type: 'select',
  name: 'language',
  choices: [{ name: 'TypeScript' }, { name: 'JavaScript' }],
  initial: 'JavaScript',
  skip: true,
}]));

... resolves to { language: 'TypeScript' }

using the choice index instead:

initial: 1

... resolves to { language: 'JavaScript' }

[karlhorky]

ah that didn't fix the test failure though, trying this enquirer dynamic skip() instead:

• 6b96831

[karlhorky]

this is needed so that the skip() method below can access this.options from the outer scope but still the this.index from the skip() scope

[karlhorky]

allow omitting the options argument, so that all options can be passed via CLI flags

[Copilot]

Pull request overview

Adds explicit control over GitHub Actions workflow generation so that passing --gha or --no-gha is treated as an answered prompt (skipping the interactive question), and updates integration coverage for both quiet and non-quiet flows.

Changes:

• Add --no-gha CLI flag and update prompt behavior so explicit --gha/--no-gha skips the GHA question.
• Adjust the language select prompt skip behavior to correctly resolve --lang js in the non-quiet path.
• Extend integration tests and fixtures to support running the real CLI prompt flow (by omitting TEST_OPTIONS when desired).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
tests/integration.spec.ts	Adds integration coverage for explicit GHA flags in quiet and non-quiet scenarios.
tests/baseFixtures.ts	Makes run() prompt overrides optional so tests can exercise real prompt/CLI behavior.
src/generator.ts	Treats explicit gha option as answered (skip prompt) and adjusts language selection skip behavior.
src/cli.ts	Introduces --no-gha flag to explicitly disable workflow generation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Defining both --gha and --no-gha as separate .option() entries will conflict because Commander derives the same option name (gha) for both (it strips the no- prefix). With Commander’s negated options, this can either throw at startup or (more subtly) make options.gha default to true, which would cause Generator to treat GHA as explicitly answered and skip the prompt / install the workflow even when the user did not pass any GHA flag.

To keep the intended tri-state (undefined when not provided, true for --gha, false for --no-gha), consider using a single negatable option (e.g. --[no-]gha) and then only populating cliOptions.gha when the value source is cli (via command.getOptionValueSource('gha')), otherwise leave it undefined.

[karlhorky]

AI slop

without .option('--no-gha', ...), there is no explicit false case to pass through to Generator.

this was tested locally with commander before the change:

• without .option('--no-gha', ...)
  • no flag => options.gha === undefined
  • --gha => true
  • --no-gha => unknown option error
• with .option('--no-gha', ...)
  • no flag => options.gha === undefined
  • --gha => true
  • --no-gha => false

so this does not default options.gha to true when no GHA flag is passed

[karlhorky]

the initial string literals apparently was broken with enquirer for longer:

import enquirer from 'enquirer';
const { prompt } = enquirer;

console.log(await prompt([{
  type: 'select',
  name: 'language',
  choices: [{ name: 'TypeScript' }, { name: 'JavaScript' }],
  initial: 'JavaScript',
  skip: true,
}]));

... resolves to { language: 'TypeScript' }

using the choice index instead:

initial: 1

... resolves to { language: 'JavaScript' }

---

first approach: since it caused test failures for this PR, I originally tried to switch to setting initial with a number:

-        initial: this.options.lang === 'js' ? 'JavaScript' : 'TypeScript',
+        initial: this.options.lang === 'js' ? 1 : 0,
         skip: !!this.options.lang,

but that still fails when the prompt is skipped. enquirer never applies the select prompt’s initial during the skipped path, so both forms still resolve to the first choice (TypeScript), which is what was breaking the non-quiet --lang js test here.

---

so the solution is to use the skip() method form, and set the value via this.index

[karlhorky]

I think the CI failure is some kind of unrelated flakiness:

  1) [npm] › tests/integration.spec.ts:89:5 › should generate be able to run JS examples successfully 

    Error: Failed to run "npx playwright install-deps"
    stdout:
    Installing dependencies...
    Switching to root user to install dependencies...
    Reading package lists...
    Failed to install browser dependencies
    Error: Installation process exited with code: 100

    stderr:
    E: Could not get lock /var/lib/apt/lists/lock. It is held by process 8040 (apt-get)
    E: Unable to lock directory /var/lib/apt/lists/


       at baseFixtures.ts:77

      75 |       });
      76 |       if (result.code !== 0) {
    > 77 |         throw new Error([
         |               ^
      78 |           `Failed to run "${cmd} ${args.join(' ')}"`,
      79 |           `stdout:`,
      80 |           result.stdout,
        at /home/runner/work/create-playwright/create-playwright/tests/baseFixtures.ts:77:15
        at /home/runner/work/create-playwright/create-playwright/tests/integration.spec.ts:96:3

  1 failed
    [npm] › tests/integration.spec.ts:89:5 › should generate be able to run JS examples successfully